Review Request 114076: Set KDE4_INCLUDES in KDE4SupportConfig

[David Faure]

> On Nov. 24, 2013, 9:20 p.m., Stephen Kelly wrote:
> > tier4/kde4support/KDE4SupportConfig.cmake.in, line 38
> > <http://git.reviewboard.kde.org/r/114076/diff/1/?file=219450#file219450line38>
> >
> >     Why is it necessary to set KDE4_INCLUDES at all? The correct include dirs should all come from the IMPORTED targets. 
> >     
> >     What is the error encountered?

If you do this in kde-runtime/CMakeLists.txt:

 find_package(KDE4Support REQUIRED NO_MODULE)
-find_package(KDELibs4 REQUIRED NO_MODULE)

then ktimezoned won't find KConfigGroup, due to ${KDE4_INCLUDE_DIR}/KDE missing from the include path.

It doesn't link to kde4support, and KConfigCore doesn't install forwarding headers yet. So this is a temporary measure, the real fix being to generate and install forwarding headers; but this fix allows to move the two things forward independently.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114076/#review44353
-----------------------------------------------------------


On Nov. 24, 2013, 2:07 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114076/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2013, 2:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Set KDE4_INCLUDES in KDE4SupportConfig.
> 
> This allows to compile kde-runtime without find_package(KDELibs4),
> which seems otherwise redundant with find_package(KDE4Support).
> 
> 
> Diffs
> -----
> 
>   tier4/kde4support/KDE4SupportConfig.cmake.in 1a8c9c4 
> 
> Diff: http://git.reviewboard.kde.org/r/114076/diff/
> 
> 
> Testing
> -------
> 
> kde-runtime compiles without find_package(KDELibs4)
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131124/59ec87a6/attachment.html>