Review Request 113910: Add basic KArchive examples

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113910/#review44355
-----------------------------------------------------------


> Looking for feedback on:
> License? Currently BSD.

BSD is one of the acceptable licenses:

 http://techbase.kde.org/Policies/Licensing_Policy

That page doesn't specify anything in particular about license for example code. Perhaps it should, but that doesn't affect this patch of course :).

> Code comments. More, less?
> Readability?

Looks good to me.

> Other examples I'm working on:
> helloworld with qmake
> something with KCompressionDevice
> perhaps a minimal ark like example

Thanks for working on this! It's a great initiative.


tier1/karchive/examples/helloworld/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113910/#comment31720>

    It might make sense to add the REQUIRED keyword here, and possibly even a version, to show good practice.


- Stephen Kelly


On Nov. 20, 2013, 6:50 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113910/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2013, 6:50 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This adds 2 examples to KArchive.
> - helloworld: Very basic. Shows how to use with CMake and create archives.
> - tarlocalfiles: Shows how to add local files to an archive.
> 
> Looking for feedback on:
> License? Currently BSD.
> Code comments. More, less?
> Readability?
> 
> Other examples I'm working on:
> helloworld with qmake
> something with KCompressionDevice
> perhaps a minimal ark like example
> 
> 
> Diffs
> -----
> 
>   tier1/karchive/examples/helloworld/CMakeLists.txt PRE-CREATION 
>   tier1/karchive/examples/helloworld/main.cpp PRE-CREATION 
>   tier1/karchive/examples/tarlocalfiles/CMakeLists.txt PRE-CREATION 
>   tier1/karchive/examples/tarlocalfiles/main.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113910/diff/
> 
> 
> Testing
> -------
> 
> Builds and runs without errors.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131124/8f6a0e6a/attachment.html>