Review Request 113910: Add basic KArchive examples

Maarten De Meyer de.meyer.maarten at gmail.com
Mon Nov 25 12:35:29 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113910/
-----------------------------------------------------------

(Updated Nov. 25, 2013, 12:35 p.m.)


Review request for KDE Frameworks.


Changes
-------

Simplify the example.
Add REQUIRED keyword


Repository: kdelibs


Description
-------

This adds 2 examples to KArchive.
- helloworld: Very basic. Shows how to use with CMake and create archives.
- tarlocalfiles: Shows how to add local files to an archive.

Looking for feedback on:
License? Currently BSD.
Code comments. More, less?
Readability?

Other examples I'm working on:
helloworld with qmake
something with KCompressionDevice
perhaps a minimal ark like example


Diffs (updated)
-----

  tier1/karchive/examples/tarlocalfiles/main.cpp PRE-CREATION 
  tier1/karchive/examples/tarlocalfiles/CMakeLists.txt PRE-CREATION 
  tier1/karchive/examples/helloworld/main.cpp PRE-CREATION 
  tier1/karchive/examples/helloworld/CMakeLists.txt PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/113910/diff/


Testing
-------

Builds and runs without errors.


Thanks,

Maarten De Meyer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131125/3c55a1b4/attachment.html>


More information about the Kde-frameworks-devel mailing list