Review Request 113910: Add basic KArchive examples

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113910/#review44222
-----------------------------------------------------------



tier1/karchive/examples/helloworld/main.cpp
<http://git.reviewboard.kde.org/r/113910/#comment31673>

    Space after if before the opening parenthesis (please do it everywhere in the other example too)



tier1/karchive/examples/tarlocalfiles/main.cpp
<http://git.reviewboard.kde.org/r/113910/#comment31672>

    It's kind of odd to do that, if no file is given just show a error message to explain the syntax and exit.



tier1/karchive/examples/tarlocalfiles/main.cpp
<http://git.reviewboard.kde.org/r/113910/#comment31671>

    No need to take this into account.


- Kevin Ottens


On Nov. 20, 2013, 6:50 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113910/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2013, 6:50 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This adds 2 examples to KArchive.
> - helloworld: Very basic. Shows how to use with CMake and create archives.
> - tarlocalfiles: Shows how to add local files to an archive.
> 
> Looking for feedback on:
> License? Currently BSD.
> Code comments. More, less?
> Readability?
> 
> Other examples I'm working on:
> helloworld with qmake
> something with KCompressionDevice
> perhaps a minimal ark like example
> 
> 
> Diffs
> -----
> 
>   tier1/karchive/examples/helloworld/CMakeLists.txt PRE-CREATION 
>   tier1/karchive/examples/helloworld/main.cpp PRE-CREATION 
>   tier1/karchive/examples/tarlocalfiles/CMakeLists.txt PRE-CREATION 
>   tier1/karchive/examples/tarlocalfiles/main.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113910/diff/
> 
> 
> Testing
> -------
> 
> Builds and runs without errors.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131122/c4a607cf/attachment.html>