Review Request 110418: Move KNumInput to KDE4Support

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110418/#review32485
-----------------------------------------------------------


Almost good, except that this patch will need to be completed once https://codereview.qt-project.org/#change,54764 reaches qt5.git

We should probably ask for an update of qt5.git soon now.


kdeui/dialogs/kinputdialog.cpp
<http://git.reviewboard.kde.org/r/110418/#comment24159>

    You lost the base parameter here, it must be kept and used. We need a patch for QSpinBox for that, I got it merged but qt5.git didn't get updated yet we have to wait for it.
    Once this patch gets in QSpinBox will have a displayBase property that you'll be able to use.



kdeui/dialogs/kinputdialog.cpp
<http://git.reviewboard.kde.org/r/110418/#comment24158>

    Spurious whitespace



kdeui/dialogs/kinputdialog_p.h
<http://git.reviewboard.kde.org/r/110418/#comment24160>

    Base must be kept.


- Kevin Ottens


On May 13, 2013, 4:29 p.m., Anne-Marie Mahfouf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110418/
> -----------------------------------------------------------
> 
> (Updated May 13, 2013, 4:29 p.m.)
> 
> 
> Review request for KDE Frameworks and Kevin Ottens.
> 
> 
> Description
> -------
> 
> Move KNumInput to KDE4Support, use QSpinBox or QDoubleSpinBox instead.
> Test moved as well.
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt 3e18c2a 
>   kdeui/dialogs/kconfigdialogmanager.cpp 620f0b5 
>   kdeui/dialogs/kinputdialog.cpp 6cbd881 
>   kdeui/dialogs/kinputdialog_p.h dcdff3f 
>   kdeui/tests/CMakeLists.txt 69be059 
>   kdeui/tests/knuminputtest.h 5c41e28 
>   kdeui/tests/knuminputtest.cpp 6387337 
>   kdeui/tests/krulertest.h fc677c6 
>   kdeui/tests/krulertest.cpp 9686421 
>   kdeui/widgets/knuminput.h 06d1ebd 
>   kdeui/widgets/knuminput.cpp 8a288a5 
>   kdewidgets/kde.widgets 6ccdcb65 
>   kdewidgets/kdedeprecated.qrc 6152a80 
>   kdewidgets/kdedeprecated.widgets cda6929 
>   kdewidgets/kdewidgets.qrc 0a741e5 
>   staging/kde4support/src/CMakeLists.txt 354a278 
>   staging/kde4support/src/kdeui/kcolordialog.cpp 041c06a 
>   staging/kde4support/src/kdeui/knuminput.h PRE-CREATION 
>   staging/kde4support/src/kdeui/knuminput.cpp PRE-CREATION 
>   staging/kde4support/tests/CMakeLists.txt e3e42ba 
>   staging/kde4support/tests/knuminputtest.h PRE-CREATION 
>   staging/kde4support/tests/knuminputtest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110418/diff/
> 
> 
> Testing
> -------
> 
> Build tested
> 
> 
> Thanks,
> 
> Anne-Marie Mahfouf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130514/8fee367b/attachment.html>