Review Request 110418: Move KNumInput to KDE4Support

Anne-Marie Mahfouf annma at kde.org
Tue May 28 19:44:40 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110418/
-----------------------------------------------------------

(Updated May 28, 2013, 7:44 p.m.)


Review request for KDE Frameworks and Kevin Ottens.


Changes
-------

Use setDisplayIntegerBase(base) from QSpinBox as it reached Qt5.


Description
-------

Move KNumInput to KDE4Support, use QSpinBox or QDoubleSpinBox instead.
Test moved as well.


Diffs (updated)
-----

  kdeui/dialogs/kconfigdialogmanager.cpp 87c3e48 
  kdeui/dialogs/kinputdialog.cpp 6cbd881 
  kdeui/dialogs/kinputdialog_p.h dcdff3f 
  kdeui/tests/krulertest.h fc677c6 
  kdeui/tests/krulertest.cpp 9686421 
  staging/kde4support/src/kdeui/kcolordialog.cpp 041c06a 

Diff: http://git.reviewboard.kde.org/r/110418/diff/


Testing
-------

Build tested


Thanks,

Anne-Marie Mahfouf

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130528/d93d25d3/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list