<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110418/">http://git.reviewboard.kde.org/r/110418/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Almost good, except that this patch will need to be completed once https://codereview.qt-project.org/#change,54764 reaches qt5.git
We should probably ask for an update of qt5.git soon now.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110418/diff/1/?file=143513#file143513line121" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/dialogs/kinputdialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KInputDialogHelper::KInputDialogHelper( const QString &caption, const QString &label,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">120</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">int</span> <span class="n">value</span><span class="p">,</span> <span class="kt">int</span> <span class="n">minValue</span><span class="p">,</span> <span class="kt">int</span> <span class="n">maxValue</span><span class="p">,</span> <span class="kt">int</span> <span class="n">step</span><span class="p">,</span> <span class="kt"><span class="hl">int</span></span><span class="hl"> </span><span class="n"><span class="hl">base</span></span><span class="p"><span class="hl">,</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">120</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">int</span> <span class="n">value</span><span class="p">,</span> <span class="kt">int</span> <span class="n">minValue</span><span class="p">,</span> <span class="kt">int</span> <span class="n">maxValue</span><span class="p">,</span> <span class="kt">int</span> <span class="n">step</span><span class="p">,</span><span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You lost the base parameter here, it must be kept and used. We need a patch for QSpinBox for that, I got it merged but qt5.git didn't get updated yet we have to wait for it.
Once this patch gets in QSpinBox will have a displayBase property that you'll be able to use.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110418/diff/1/?file=143513#file143513line142" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/dialogs/kinputdialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KInputDialogHelper::KInputDialogHelper( const QString &caption, const QString &label,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">141</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Spurious whitespace</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110418/diff/1/?file=143514#file143514line52" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/dialogs/kinputdialog_p.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class KInputDialogHelper : public QDialog</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">51</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">int</span> <span class="n">minValue</span><span class="p">,</span> <span class="kt">int</span> <span class="n">maxValue</span><span class="p">,</span> <span class="kt">int</span> <span class="n">step</span><span class="p">,</span> <span class="kt"><span class="hl">int</span></span><span class="hl"> </span><span class="n"><span class="hl">base</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n">QWidget</span> <span class="o">*</span><span class="n">parent</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">51</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">int</span> <span class="n">minValue</span><span class="p">,</span> <span class="kt">int</span> <span class="n">maxValue</span><span class="p">,</span> <span class="kt">int</span> <span class="n">step</span><span class="p">,</span> <span class="n">QWidget</span> <span class="o">*</span><span class="n">parent</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Base must be kept.</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On May 13th, 2013, 4:29 p.m. UTC, Anne-Marie Mahfouf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Kevin Ottens.</div>
<div>By Anne-Marie Mahfouf.</div>
<p style="color: grey;"><i>Updated May 13, 2013, 4:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move KNumInput to KDE4Support, use QSpinBox or QDoubleSpinBox instead.
Test moved as well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Build tested</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(3e18c2a)</span></li>
<li>kdeui/dialogs/kconfigdialogmanager.cpp <span style="color: grey">(620f0b5)</span></li>
<li>kdeui/dialogs/kinputdialog.cpp <span style="color: grey">(6cbd881)</span></li>
<li>kdeui/dialogs/kinputdialog_p.h <span style="color: grey">(dcdff3f)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(69be059)</span></li>
<li>kdeui/tests/knuminputtest.h <span style="color: grey">(5c41e28)</span></li>
<li>kdeui/tests/knuminputtest.cpp <span style="color: grey">(6387337)</span></li>
<li>kdeui/tests/krulertest.h <span style="color: grey">(fc677c6)</span></li>
<li>kdeui/tests/krulertest.cpp <span style="color: grey">(9686421)</span></li>
<li>kdeui/widgets/knuminput.h <span style="color: grey">(06d1ebd)</span></li>
<li>kdeui/widgets/knuminput.cpp <span style="color: grey">(8a288a5)</span></li>
<li>kdewidgets/kde.widgets <span style="color: grey">(6ccdcb65)</span></li>
<li>kdewidgets/kdedeprecated.qrc <span style="color: grey">(6152a80)</span></li>
<li>kdewidgets/kdedeprecated.widgets <span style="color: grey">(cda6929)</span></li>
<li>kdewidgets/kdewidgets.qrc <span style="color: grey">(0a741e5)</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(354a278)</span></li>
<li>staging/kde4support/src/kdeui/kcolordialog.cpp <span style="color: grey">(041c06a)</span></li>
<li>staging/kde4support/src/kdeui/knuminput.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kdeui/knuminput.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/tests/CMakeLists.txt <span style="color: grey">(e3e42ba)</span></li>
<li>staging/kde4support/tests/knuminputtest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/tests/knuminputtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110418/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>