Review Request 110674: Moving KToolBarSpacerAction to KWidgetsAddons

Aleix Pol Gonzalez aleixpol at kde.org
Wed Jun 5 23:12:20 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110674/
-----------------------------------------------------------

(Updated June 5, 2013, 11:12 p.m.)


Review request for KDE Frameworks.


Changes
-------

trimmed most of it as dfaure suggested.

It's looking very slim now!


Description
-------

Just moves the file, nobody seems to be using it in kdelibs anyway.


Diffs (updated)
-----

  kdeui/CMakeLists.txt 80387ee 
  kdeui/actions/ktoolbarspaceraction.h 32e8fb2 
  kdeui/actions/ktoolbarspaceraction.cpp db79af2 
  tier1/kwidgetsaddons/src/CMakeLists.txt ea80787 
  tier1/kwidgetsaddons/src/ktoolbarspaceraction.h PRE-CREATION 
  tier1/kwidgetsaddons/src/ktoolbarspaceraction.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/110674/diff/


Testing
-------

Builds and installs fine.


File Attachments
----------------

::addSeparator()
  http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-nospaceraction.png
KToolBarSpacerAction
  http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-spaceraction.png


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130605/e2a74265/attachment.html>


More information about the Kde-frameworks-devel mailing list