Review Request 110674: Moving KToolBarSpacerAction to KWidgetsAddons

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110674/#review33839
-----------------------------------------------------------

Ship it!


Small is good :)

Just minor things left, probably doesn't need another review round.


tier1/kwidgetsaddons/src/ktoolbarspaceraction.h
<http://git.reviewboard.kde.org/r/110674/#comment24927>

    Keep a destructor explicitly spelled out in the header file, otherwise we won't be able to add one later [and make sure it's always called].



tier1/kwidgetsaddons/src/ktoolbarspaceraction.cpp
<http://git.reviewboard.kde.org/r/110674/#comment24928>

    QToolBar isn't actually used in this file, only QWidget.



tier1/kwidgetsaddons/src/ktoolbarspaceraction.cpp
<http://git.reviewboard.kde.org/r/110674/#comment24929>

    empty destructor body goes here.


- David Faure


On June 5, 2013, 11:12 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110674/
> -----------------------------------------------------------
> 
> (Updated June 5, 2013, 11:12 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Just moves the file, nobody seems to be using it in kdelibs anyway.
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt 80387ee 
>   kdeui/actions/ktoolbarspaceraction.h 32e8fb2 
>   kdeui/actions/ktoolbarspaceraction.cpp db79af2 
>   tier1/kwidgetsaddons/src/CMakeLists.txt ea80787 
>   tier1/kwidgetsaddons/src/ktoolbarspaceraction.h PRE-CREATION 
>   tier1/kwidgetsaddons/src/ktoolbarspaceraction.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110674/diff/
> 
> 
> Testing
> -------
> 
> Builds and installs fine.
> 
> 
> File Attachments
> ----------------
> 
> ::addSeparator()
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-nospaceraction.png
> KToolBarSpacerAction
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-spaceraction.png
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130605/bd26fdb8/attachment-0001.html>