Review Request 110674: Moving KToolBarSpacerAction to KWidgetsAddons

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110674/#review33824
-----------------------------------------------------------



tier1/kwidgetsaddons/src/ktoolbarspaceraction.cpp
<http://git.reviewboard.kde.org/r/110674/#comment24912>

    Hmm, I wonder, what do we need this list for, nowadays?
    
    All we do is add to it on creation, and remove from it on deletion. It doesn't seem to serve any purpose?
    I see, it was used by setWidth/setMinimumWidth/setMaximumWidth to iterate over the list. But that's gone, so the list can be removed -- and therefore _k_spacerDestroyed can be removed. This class is going to end up being extremely small, which is good :-)


- David Faure


On June 3, 2013, 4:08 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110674/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 4:08 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Just moves the file, nobody seems to be using it in kdelibs anyway.
> 
> 
> Diffs
> -----
> 
>   tier1/kwidgetsaddons/src/ktoolbarspaceraction.cpp PRE-CREATION 
>   tier1/kwidgetsaddons/src/ktoolbarspaceraction.h PRE-CREATION 
>   tier1/kwidgetsaddons/src/CMakeLists.txt df22699 
>   kdeui/actions/ktoolbarspaceraction.cpp db79af2 
>   kdeui/CMakeLists.txt 46e08df 
>   kdeui/actions/ktoolbarspaceraction.h 32e8fb2 
> 
> Diff: http://git.reviewboard.kde.org/r/110674/diff/
> 
> 
> Testing
> -------
> 
> Builds and installs fine.
> 
> 
> File Attachments
> ----------------
> 
> ::addSeparator()
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-nospaceraction.png
> KToolBarSpacerAction
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-spaceraction.png
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130605/c50c5830/attachment.html>