<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110674/">http://git.reviewboard.kde.org/r/110674/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110674/diff/4/?file=147977#file147977line35" style="color: black; font-weight: bold; text-decoration: underline;">tier1/kwidgetsaddons/src/ktoolbarspaceraction.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">35</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QList</span><span class="o"><</span><span class="n">QWidget</span><span class="o">*></span> <span class="n">spacers</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, I wonder, what do we need this list for, nowadays?
All we do is add to it on creation, and remove from it on deletion. It doesn't seem to serve any purpose?
I see, it was used by setWidth/setMinimumWidth/setMaximumWidth to iterate over the list. But that's gone, so the list can be removed -- and therefore _k_spacerDestroyed can be removed. This class is going to end up being extremely small, which is good :-)</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On June 3rd, 2013, 4:08 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated June 3, 2013, 4:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just moves the file, nobody seems to be using it in kdelibs anyway.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds and installs fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kwidgetsaddons/src/ktoolbarspaceraction.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kwidgetsaddons/src/ktoolbarspaceraction.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kwidgetsaddons/src/CMakeLists.txt <span style="color: grey">(df22699)</span></li>
<li>kdeui/actions/ktoolbarspaceraction.cpp <span style="color: grey">(db79af2)</span></li>
<li>kdeui/CMakeLists.txt <span style="color: grey">(46e08df)</span></li>
<li>kdeui/actions/ktoolbarspaceraction.h <span style="color: grey">(32e8fb2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110674/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-nospaceraction.png">::addSeparator()</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-spaceraction.png">KToolBarSpacerAction</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>