Review Request 110815: Move KPassivePopup to KWidgetAddons

Aleix Pol Gonzalez aleixpol at kde.org
Wed Jun 5 14:12:17 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110815/
-----------------------------------------------------------

(Updated June 5, 2013, 2:12 p.m.)


Review request for KDE Frameworks.


Changes
-------

Followed dfaure's instructions, applied the change suggested by the TODO comment


Description
-------

Moved kpassivepopup to kwidgetaddons, from the KDEUI crumble


Diffs (updated)
-----

  tier1/kwidgetsaddons/src/kpassivepopup.cpp PRE-CREATION 
  tier1/kwidgetsaddons/src/kpassivepopup.h PRE-CREATION 
  tier1/kwidgetsaddons/src/CMakeLists.txt 1a2c3e7 
  kdeui/util/kpassivepopup.cpp e0c96da 
  kdeui/util/kpassivepopup.h 83d8f7c 
  kdeui/tests/kpassivepopuptest.cpp 6a56e99 
  kdeui/tests/kpassivepopuptest.h c9620b9 
  kdeui/CMakeLists.txt 8e2c067 
  kdeui/tests/CMakeLists.txt af65f34 
  tier1/kwidgetsaddons/tests/CMakeLists.txt 85a8732 
  tier1/kwidgetsaddons/tests/kpassivepopuptest.h PRE-CREATION 
  tier1/kwidgetsaddons/tests/kpassivepopuptest.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/110815/diff/


Testing
-------

It builds fine


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130605/891b752d/attachment.html>


More information about the Kde-frameworks-devel mailing list