<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110815/">http://git.reviewboard.kde.org/r/110815/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>


<p style="color: grey;"><i>Updated June 5, 2013, 2:12 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Followed dfaure's instructions, applied the change suggested by the TODO comment</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Moved kpassivepopup to kwidgetaddons, from the KDEUI crumble</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It builds fine</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>tier1/kwidgetsaddons/src/kpassivepopup.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/src/kpassivepopup.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/src/CMakeLists.txt <span style="color: grey">(1a2c3e7)</span></li>

 <li>kdeui/util/kpassivepopup.cpp <span style="color: grey">(e0c96da)</span></li>

 <li>kdeui/util/kpassivepopup.h <span style="color: grey">(83d8f7c)</span></li>

 <li>kdeui/tests/kpassivepopuptest.cpp <span style="color: grey">(6a56e99)</span></li>

 <li>kdeui/tests/kpassivepopuptest.h <span style="color: grey">(c9620b9)</span></li>

 <li>kdeui/CMakeLists.txt <span style="color: grey">(8e2c067)</span></li>

 <li>kdeui/tests/CMakeLists.txt <span style="color: grey">(af65f34)</span></li>

 <li>tier1/kwidgetsaddons/tests/CMakeLists.txt <span style="color: grey">(85a8732)</span></li>

 <li>tier1/kwidgetsaddons/tests/kpassivepopuptest.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/tests/kpassivepopuptest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110815/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>