Review Request 110815: Move KPassivePopup to KWidgetAddons

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110815/#review33769
-----------------------------------------------------------


Looks good. Forced me to read the API, though....


tier1/kwidgetsaddons/src/kpassivepopup.h
<http://git.reviewboard.kde.org/r/110815/#comment24892>

    Maybe we should do this now...



tier1/kwidgetsaddons/src/kpassivepopup.h
<http://git.reviewboard.kde.org/r/110815/#comment24891>

    OK, that one *is* actually still virtual in QWidget. Add Q_DECL_OVERRIDE then, so the compiler checks in the future, rather than me :-)


- David Faure


On June 3, 2013, 4:19 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110815/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 4:19 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Moved kpassivepopup to kwidgetaddons, from the KDEUI crumble
> 
> 
> Diffs
> -----
> 
>   kdeui/util/kpassivepopup.h 83d8f7c 
>   kdeui/tests/kpassivepopuptest.cpp 6a56e99 
>   kdeui/tests/kpassivepopuptest.h c9620b9 
>   kdeui/tests/CMakeLists.txt 5c1f386 
>   kdeui/CMakeLists.txt 46e08df 
>   kdeui/util/kpassivepopup.cpp e0c96da 
>   tier1/kwidgetsaddons/src/CMakeLists.txt df22699 
>   tier1/kwidgetsaddons/src/kpassivepopup.h PRE-CREATION 
>   tier1/kwidgetsaddons/src/kpassivepopup.cpp PRE-CREATION 
>   tier1/kwidgetsaddons/tests/CMakeLists.txt de5e6e4 
>   tier1/kwidgetsaddons/tests/kpassivepopuptest.h PRE-CREATION 
>   tier1/kwidgetsaddons/tests/kpassivepopuptest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110815/diff/
> 
> 
> Testing
> -------
> 
> It builds fine
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130604/df1a8ace/attachment.html>