Review Request 110833: Remove KIconLoader dependency to KWidgets
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Jun 4 23:56:01 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110833/
-----------------------------------------------------------
Review request for KDE Frameworks and David Faure.
Description
-------
As we discussed in the IRC meeting, I removed the KIconLoader dependency to KWidgets (so that we can make KWidgets depend on KIconLoader).
I'm unsure if it's the best approach, so I tried to do the simplest implementation I could. Don't hesitate to suggest changes.
Diffs
-----
staging/kiconthemes/src/kiconloader.h e4423eb
staging/kiconthemes/src/CMakeLists.txt 82828dc
staging/kiconthemes/src/kiconloader.cpp 795ec93
staging/kwidgets/src/utils/kglobalsettings.cpp 53b648e
Diff: http://git.reviewboard.kde.org/r/110833/diff/
Testing
-------
it builds
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130604/0c411fef/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list