Review Request 110833: Remove KIconLoader dependency to KWidgets

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110833/#review33781
-----------------------------------------------------------



staging/kiconthemes/src/kiconloader.h
<http://git.reviewboard.kde.org/r/110833/#comment24902>

    @deprecated since 5.0, use iconChanged(int)



staging/kiconthemes/src/kiconloader.h
<http://git.reviewboard.kde.org/r/110833/#comment24901>

    @since 5.0



staging/kwidgets/src/utils/kglobalsettings.cpp
<http://git.reviewboard.kde.org/r/110833/#comment24903>

    Hmm, but what if KGlobalSettings wasn't created? (there's still hope that we can deprecate it, even...)
    
    I don't think KIconLoader should rely on KGlobalSettings -- you replaced a compile-time dependency with a runtime dependency.
    
    Let's use a different DBus signal instead, in both classes.


- David Faure


On June 4, 2013, 11:56 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110833/
> -----------------------------------------------------------
> 
> (Updated June 4, 2013, 11:56 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> As we discussed in the IRC meeting, I removed the KIconLoader dependency to KWidgets (so that we can make KWidgets depend on KIconLoader).
> 
> I'm unsure if it's the best approach, so I tried to do the simplest implementation I could. Don't hesitate to suggest changes.
> 
> 
> Diffs
> -----
> 
>   staging/kiconthemes/src/kiconloader.h e4423eb 
>   staging/kiconthemes/src/CMakeLists.txt 82828dc 
>   staging/kiconthemes/src/kiconloader.cpp 795ec93 
>   staging/kwidgets/src/utils/kglobalsettings.cpp 53b648e 
> 
> Diff: http://git.reviewboard.kde.org/r/110833/diff/
> 
> 
> Testing
> -------
> 
> it builds
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130605/542189e9/attachment.html>