Review Request 109480: Add support for xcb_generic_event_t to KKeyServer::xEventToQt
Commit Hook
null at kde.org
Mon Jul 29 06:55:13 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109480/#review36701
-----------------------------------------------------------
This review has been submitted with commit 373d812a636da898a0f1cc017fa2c9dd4ff50381 by Martin Gräßlin to branch frameworks.
- Commit Hook
On July 26, 2013, 7:49 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109480/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 7:49 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Allows converting an xcb key event to Qt key + modifier code just like
> the existing code for a XEvent. Slight difference: instead of an assert
> the method returns false in case it's not a key event.
>
>
> Diffs
> -----
>
> tier1/kwindowsystem/src/CMakeLists.txt 6544585
> tier1/kwindowsystem/src/kkeyserver_x11.h cb0b2be
> tier1/kwindowsystem/src/kkeyserver_x11.cpp 28bfedd
>
> Diff: http://git.reviewboard.kde.org/r/109480/diff/
>
>
> Testing
> -------
>
> it compiles :-) I'm currently lacking ideas how to unit test it. If I don't find a solution I will notice once I'm running KWin on top of KF5
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130729/60577be7/attachment.html>
More information about the Kde-frameworks-devel
mailing list