Review Request 109480: Add support for xcb_generic_event_t to KKeyServer::xEventToQt

[Martin Gräßlin]

> On July 27, 2013, 9:52 a.m., David Faure wrote:
> > tier1/kwindowsystem/src/kkeyserver_x11.h, line 170
> > <http://git.reviewboard.kde.org/r/109480/diff/2/?file=173749#file173749line170>
> >
> >     The double semicolon isn't really useful :)

I need to fix my kdevelop - that's the second time it happened in one week ;-)


> On July 27, 2013, 9:52 a.m., David Faure wrote:
> > tier1/kwindowsystem/src/kkeyserver_x11.cpp, line 909
> > <http://git.reviewboard.kde.org/r/109480/diff/2/?file=173750#file173750line909>
> >
> >     If this method always returns true, the bool ret val isn't useful... Do you see a possibility that it might return false in the future?

probably some error checking could be done for cases that there is no Qt key for the keysym. Apart from that it's for symmetry - the method for XEvent also only return true.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109480/#review36578
-----------------------------------------------------------


On July 26, 2013, 9:49 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109480/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 9:49 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Allows converting an xcb key event to Qt key + modifier code just like
> the existing code for a XEvent. Slight difference: instead of an assert
> the method returns false in case it's not a key event.
> 
> 
> Diffs
> -----
> 
>   tier1/kwindowsystem/src/CMakeLists.txt 6544585 
>   tier1/kwindowsystem/src/kkeyserver_x11.h cb0b2be 
>   tier1/kwindowsystem/src/kkeyserver_x11.cpp 28bfedd 
> 
> Diff: http://git.reviewboard.kde.org/r/109480/diff/
> 
> 
> Testing
> -------
> 
> it compiles :-) I'm currently lacking ideas how to unit test it. If I don't find a solution I will notice once I'm running KWin on top of KF5
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130727/d18cd343/attachment.html>