Review Request 109480: Add support for xcb_generic_event_t to KKeyServer::xEventToQt
Commit Hook
null at kde.org
Mon Jul 29 06:55:19 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109480/
-----------------------------------------------------------
(Updated July 29, 2013, 6:55 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Description
-------
Allows converting an xcb key event to Qt key + modifier code just like
the existing code for a XEvent. Slight difference: instead of an assert
the method returns false in case it's not a key event.
Diffs
-----
tier1/kwindowsystem/src/CMakeLists.txt 6544585
tier1/kwindowsystem/src/kkeyserver_x11.h cb0b2be
tier1/kwindowsystem/src/kkeyserver_x11.cpp 28bfedd
Diff: http://git.reviewboard.kde.org/r/109480/diff/
Testing
-------
it compiles :-) I'm currently lacking ideas how to unit test it. If I don't find a solution I will notice once I'm running KWin on top of KF5
Thanks,
Martin Gräßlin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130729/f3e56dce/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list