Review Request 111723: Port KNewPasswordDialog to KWidgetAddons
David Edmundson
david at davidedmundson.co.uk
Sun Jul 28 12:16:21 UTC 2013
> On July 27, 2013, 3:21 p.m., David Faure wrote:
> > kdeui/dialogs/knewpassworddialog.ui, line 64
> > <http://git.reviewboard.kde.org/r/111723/diff/1/?file=173859#file173859line64>
> >
> > why were the buddy properties lost?
because I am rubbish.
Accidentally deleted in klineedit -> qlineedit, and didn't notice in QtDesigner
Well spotted.
Fixed in update.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111723/#review36605
-----------------------------------------------------------
On July 28, 2013, 12:16 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111723/
> -----------------------------------------------------------
>
> (Updated July 28, 2013, 12:16 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Move KNewPasswordDialog to KWidgetAddons
>
>
> Diffs
> -----
>
> kdeui/CMakeLists.txt 8409c03dbd96d8aafa42ce20fe8678b6b208f4d8
> kdeui/dialogs/knewpassworddialog.h 1db0d8ff43029eabe4d7c9bf8ee43c2b7038013a
> kdeui/dialogs/knewpassworddialog.cpp e4e17e2149be83f60f95d1b67f6ab12082dfb37e
> kdeui/dialogs/knewpassworddialog.ui 51e980c3ec58370c3c4e8b52c9b12b6204afa97b
> kdeui/tests/CMakeLists.txt 92ebee7f48fb614f342edcb71d317a125c590290
> kdeui/tests/knewpassworddialogtest.cpp 1ddee7d06bd145036ef80f09e350c1fba6e7d7d5
> tier1/kwidgetsaddons/src/CMakeLists.txt 01c23082667de304f08d7a394385b1ff928412a5
> tier1/kwidgetsaddons/src/knewpassworddialog.h PRE-CREATION
> tier1/kwidgetsaddons/src/knewpassworddialog.cpp PRE-CREATION
> tier1/kwidgetsaddons/src/knewpassworddialog.ui PRE-CREATION
> tier1/kwidgetsaddons/tests/CMakeLists.txt 403eff1555b886a4bb03f40fb2813d9ccd8bcd82
> tier1/kwidgetsaddons/tests/knewpassworddialogtest.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/111723/diff/
>
>
> Testing
> -------
>
> Ran included test app.
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130728/febed4bb/attachment.html>
More information about the Kde-frameworks-devel
mailing list