<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111723/">http://git.reviewboard.kde.org/r/111723/</a>
     </td>
    </tr>
   </table>
   <br />










<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On July 27th, 2013, 3:21 p.m. UTC, <b>David Faure</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/111723/diff/1/?file=173859#file173859line64" style="color: black; font-weight: bold; text-decoration: underline;">tier1/kwidgetsaddons/src/knewpassworddialog.ui</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">56</font></th>
    <td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">       <property name="buddy"></pre></td>
    <th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why were the buddy properties lost?</pre>
 </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">because I am rubbish. 
Accidentally deleted in klineedit -> qlineedit, and didn't notice in QtDesigner

Well spotted. 
Fixed in update.</pre>
<br />




<p>- David</p>


<br />
<p>On July 28th, 2013, 12:16 p.m. UTC, David Edmundson wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By David Edmundson.</div>


<p style="color: grey;"><i>Updated July 28, 2013, 12:16 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move KNewPasswordDialog to KWidgetAddons</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran included test app.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kdeui/CMakeLists.txt <span style="color: grey">(8409c03dbd96d8aafa42ce20fe8678b6b208f4d8)</span></li>

 <li>kdeui/dialogs/knewpassworddialog.h <span style="color: grey">(1db0d8ff43029eabe4d7c9bf8ee43c2b7038013a)</span></li>

 <li>kdeui/dialogs/knewpassworddialog.cpp <span style="color: grey">(e4e17e2149be83f60f95d1b67f6ab12082dfb37e)</span></li>

 <li>kdeui/dialogs/knewpassworddialog.ui <span style="color: grey">(51e980c3ec58370c3c4e8b52c9b12b6204afa97b)</span></li>

 <li>kdeui/tests/CMakeLists.txt <span style="color: grey">(92ebee7f48fb614f342edcb71d317a125c590290)</span></li>

 <li>kdeui/tests/knewpassworddialogtest.cpp <span style="color: grey">(1ddee7d06bd145036ef80f09e350c1fba6e7d7d5)</span></li>

 <li>tier1/kwidgetsaddons/src/CMakeLists.txt <span style="color: grey">(01c23082667de304f08d7a394385b1ff928412a5)</span></li>

 <li>tier1/kwidgetsaddons/src/knewpassworddialog.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/src/knewpassworddialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/src/knewpassworddialog.ui <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier1/kwidgetsaddons/tests/CMakeLists.txt <span style="color: grey">(403eff1555b886a4bb03f40fb2813d9ccd8bcd82)</span></li>

 <li>tier1/kwidgetsaddons/tests/knewpassworddialogtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111723/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>