Review Request 111723: Port KNewPasswordDialog to KWidgetAddons

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111723/#review36605
-----------------------------------------------------------


Looks good, just one question.


kdeui/dialogs/knewpassworddialog.ui
<http://git.reviewboard.kde.org/r/111723/#comment27012>

    why were the buddy properties lost?


- David Faure


On July 26, 2013, 4:10 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111723/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 4:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Move KNewPasswordDialog to KWidgetAddons
> 
> 
> Diffs
> -----
> 
>   tier1/kwidgetsaddons/tests/CMakeLists.txt 403eff1 
>   kdeui/tests/knewpassworddialogtest.cpp 1ddee7d 
>   tier1/kwidgetsaddons/src/CMakeLists.txt 01c2308 
>   kdeui/tests/CMakeLists.txt 92ebee7 
>   kdeui/dialogs/knewpassworddialog.ui 51e980c 
>   kdeui/dialogs/knewpassworddialog.cpp e4e17e2 
>   kdeui/CMakeLists.txt 8409c03 
>   kdeui/dialogs/knewpassworddialog.h 1db0d8f 
> 
> Diff: http://git.reviewboard.kde.org/r/111723/diff/
> 
> 
> Testing
> -------
> 
> Ran included test app.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130727/d436306e/attachment-0001.html>