Review Request 109480: Add support for xcb_generic_event_t to KKeyServer::xEventToQt

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109480/#review36578
-----------------------------------------------------------

Ship it!


Looks good, just two small comments.


tier1/kwindowsystem/src/kkeyserver_x11.h
<http://git.reviewboard.kde.org/r/109480/#comment26985>

    The double semicolon isn't really useful :)



tier1/kwindowsystem/src/kkeyserver_x11.cpp
<http://git.reviewboard.kde.org/r/109480/#comment26986>

    If this method always returns true, the bool ret val isn't useful... Do you see a possibility that it might return false in the future?


- David Faure


On July 26, 2013, 7:49 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109480/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 7:49 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Allows converting an xcb key event to Qt key + modifier code just like
> the existing code for a XEvent. Slight difference: instead of an assert
> the method returns false in case it's not a key event.
> 
> 
> Diffs
> -----
> 
>   tier1/kwindowsystem/src/CMakeLists.txt 6544585 
>   tier1/kwindowsystem/src/kkeyserver_x11.h cb0b2be 
>   tier1/kwindowsystem/src/kkeyserver_x11.cpp 28bfedd 
> 
> Diff: http://git.reviewboard.kde.org/r/109480/diff/
> 
> 
> Testing
> -------
> 
> it compiles :-) I'm currently lacking ideas how to unit test it. If I don't find a solution I will notice once I'm running KWin on top of KF5
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130727/10632d71/attachment.html>