Review Request 111653: Move KDEUI tests in their modules

Andrea Scarpino scarpino at kde.org
Tue Jul 23 16:41:10 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111653/
-----------------------------------------------------------

(Updated July 23, 2013, 6:41 p.m.)


Review request for KDE Frameworks.


Changes
-------

Do not touch kguiaddons stuff :-)


Description
-------

Some {auto,}test has not been moved in its respective module.

This patch move:
- kactioncollectiontest
- kcategorizedviewtest
- kcolorcollectiontest
- klinkitemselectionmodeltest
- knotificationrestrictionstest
- krulertest
in their respective modules and fix kmodifierkeyinfotest.


Diffs (updated)
-----

  kdeui/tests/klinkitemselectionmodeltest.cpp c3f7132 
  kdeui/tests/klinkitemselectionmodeltest.h  
  kdeui/tests/kcolorcollectiontest.cpp b199a3a 
  kdeui/tests/kcategorizedviewtest.cpp  
  kdeui/tests/kactioncollectiontest.cpp  
  kdeui/tests/CMakeLists.txt 19af839 
  kdeui/tests/kactioncollectiontest.h  
  kdeui/tests/knotificationrestrictionstest.cpp  
  kdeui/tests/krulertest.h  
  kdeui/tests/krulertest.cpp d94d73c 
  staging/itemviews/tests/CMakeLists.txt 46d191c 
  staging/kguiaddons/CMakeLists.txt d5e89d9 
  staging/kguiaddons/tests/kmodifierkeyinfotest.cpp 000fc28 
  staging/knotifications/tests/CMakeLists.txt 775d811 
  staging/kwidgets/tests/CMakeLists.txt 084e9f4 
  staging/xmlgui/autotests/CMakeLists.txt 8f56e2b 
  staging/xmlgui/tests/CMakeLists.txt b82364e 
  tier1/itemmodels/autotests/CMakeLists.txt 1a66642 

Diff: http://git.reviewboard.kde.org/r/111653/diff/


Testing
-------

- kactioncollectiontest: 10 passed, 0 failed, 0 skipped
- kcategorizedviewtest: works
- kcolorcollectiontest: nothing happens (do not segfault anyway)
- klinkitemselectionmodeltest: 3 passed, 0 failed, 0 skipped
- knotificationrestrictionstest: works
- krulertest: works


Thanks,

Andrea Scarpino

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130723/6793679d/attachment.html>


More information about the Kde-frameworks-devel mailing list