<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111653/">http://git.reviewboard.kde.org/r/111653/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Andrea Scarpino.</div>
<p style="color: grey;"><i>Updated July 23, 2013, 6:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do not touch kguiaddons stuff :-)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some {auto,}test has not been moved in its respective module.
This patch move:
- kactioncollectiontest
- kcategorizedviewtest
- kcolorcollectiontest
- klinkitemselectionmodeltest
- knotificationrestrictionstest
- krulertest
in their respective modules and fix kmodifierkeyinfotest.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- kactioncollectiontest: 10 passed, 0 failed, 0 skipped
- kcategorizedviewtest: works
- kcolorcollectiontest: nothing happens (do not segfault anyway)
- klinkitemselectionmodeltest: 3 passed, 0 failed, 0 skipped
- knotificationrestrictionstest: works
- krulertest: works</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/tests/klinkitemselectionmodeltest.cpp <span style="color: grey">(c3f7132)</span></li>
<li>kdeui/tests/klinkitemselectionmodeltest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/kcolorcollectiontest.cpp <span style="color: grey">(b199a3a)</span></li>
<li>kdeui/tests/kcategorizedviewtest.cpp <span style="color: grey">()</span></li>
<li>kdeui/tests/kactioncollectiontest.cpp <span style="color: grey">()</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(19af839)</span></li>
<li>kdeui/tests/kactioncollectiontest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/knotificationrestrictionstest.cpp <span style="color: grey">()</span></li>
<li>kdeui/tests/krulertest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/krulertest.cpp <span style="color: grey">(d94d73c)</span></li>
<li>staging/itemviews/tests/CMakeLists.txt <span style="color: grey">(46d191c)</span></li>
<li>staging/kguiaddons/CMakeLists.txt <span style="color: grey">(d5e89d9)</span></li>
<li>staging/kguiaddons/tests/kmodifierkeyinfotest.cpp <span style="color: grey">(000fc28)</span></li>
<li>staging/knotifications/tests/CMakeLists.txt <span style="color: grey">(775d811)</span></li>
<li>staging/kwidgets/tests/CMakeLists.txt <span style="color: grey">(084e9f4)</span></li>
<li>staging/xmlgui/autotests/CMakeLists.txt <span style="color: grey">(8f56e2b)</span></li>
<li>staging/xmlgui/tests/CMakeLists.txt <span style="color: grey">(b82364e)</span></li>
<li>tier1/itemmodels/autotests/CMakeLists.txt <span style="color: grey">(1a66642)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111653/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>