Review Request 111653: Move KDEUI tests in their modules

[Wojciech Kapuscinski]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111653/#review36387
-----------------------------------------------------------



staging/kguiaddons/CMakeLists.txt
<http://git.reviewboard.kde.org/r/111653/#comment26878>

    please comment this line.
    
    I will uncomment this when I finish my work with xcb port.
    
    With this change test only builds but can't be usable.



staging/kguiaddons/tests/CMakeLists.txt
<http://git.reviewboard.kde.org/r/111653/#comment26877>

    It will be ported away form KWidgetsAddons (see previous comment).
    
    kmodifierkeyinfotest use KLed form KWidgetAddons only for "fancy" GUI.
    
    Without changes in kguiaddons I think this patch is ok
    


- Wojciech Kapuscinski


On July 23, 2013, 2:15 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111653/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 2:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Some {auto,}test has not been moved in its respective module.
> 
> This patch move:
> - kactioncollectiontest
> - kcategorizedviewtest
> - kcolorcollectiontest
> - klinkitemselectionmodeltest
> - knotificationrestrictionstest
> - krulertest
> in their respective modules and fix kmodifierkeyinfotest.
> 
> 
> Diffs
> -----
> 
>   kdeui/tests/CMakeLists.txt 19af839 
>   kdeui/tests/kactioncollectiontest.h  
>   kdeui/tests/kactioncollectiontest.cpp  
>   kdeui/tests/kcategorizedviewtest.cpp  
>   kdeui/tests/kcolorcollectiontest.cpp b199a3a 
>   kdeui/tests/klinkitemselectionmodeltest.h  
>   kdeui/tests/klinkitemselectionmodeltest.cpp c3f7132 
>   kdeui/tests/knotificationrestrictionstest.cpp  
>   kdeui/tests/krulertest.h  
>   kdeui/tests/krulertest.cpp d94d73c 
>   staging/itemviews/tests/CMakeLists.txt 46d191c 
>   staging/kguiaddons/CMakeLists.txt d5e89d9 
>   staging/kguiaddons/tests/CMakeLists.txt afa6e3b 
>   staging/kguiaddons/tests/kmodifierkeyinfotest.cpp 000fc28 
>   staging/knotifications/tests/CMakeLists.txt 775d811 
>   staging/xmlgui/autotests/CMakeLists.txt 8f56e2b 
>   staging/xmlgui/tests/CMakeLists.txt b82364e 
>   tier1/itemmodels/autotests/CMakeLists.txt 1a66642 
> 
> Diff: http://git.reviewboard.kde.org/r/111653/diff/
> 
> 
> Testing
> -------
> 
> - kactioncollectiontest: 10 passed, 0 failed, 0 skipped
> - kcategorizedviewtest: works
> - kcolorcollectiontest: nothing happens (do not segfault anyway)
> - klinkitemselectionmodeltest: 3 passed, 0 failed, 0 skipped
> - knotificationrestrictionstest: works
> - krulertest: works
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130723/fde92d22/attachment.html>