Review Request 111491: Rename kde4support framework to KDE4Support

[Kevin Ottens]

> On July 12, 2013, 8:02 p.m., Alexander Neundorf wrote:
> > Thanks for working on this.
> > 
> > One more thing: maybe, instead of using the new target name KDE4Support everywhere directly, ${KDE4Support_LIBRARIES} could be used already now. Not within kde4support, but in kdelibs in places where ${KDE4Support_LIBRARIES} is already set. This happens currently in the toplevel CMakeLists.txt, but after add_subdirectory(staging). Maybe it could be moved before add_subdirectory(staging).
> > 
> > Then it doesn't have to be changed again later on when kde4support will have moved from staging to an independent framework. The name of the imported target will then be "KF5::KDE4Support", while it is now "KDE4__kde4support", and by using the variable ${KDE4Support_LIBRARIES} users are isolated from such changes.
> >

Please discuss that with Stephen then. I thought the consensus the last time it got discussed was to use target names directly. Which is what we've been doing everywhere so far.

So I advise the following:
 * Discuss that again if you feel that's needed, depending on the conclusion we will adjust (or not) our CMakeLists.txt files
 * Let this patch and its friends in, if something is unclear on that topic it's no reason to block them.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111491/#review35902
-----------------------------------------------------------


On July 12, 2013, 12:49 p.m., Benjamin Port wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111491/
> -----------------------------------------------------------
> 
> (Updated July 12, 2013, 12:49 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> In order to have all frameworks using the same name policy (i.e. use CamelCase for libraries names) rename kde4support framework lib to KDE4Support
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a03f33b 
>   cmake/modules/FindKDE4Internal.cmake 8786a9d 
>   interfaces/kimproxy/library/CMakeLists.txt 5bc4b4d 
>   kdeui/tests/CMakeLists.txt b6d5b30 
>   kdewidgets/CMakeLists.txt 1f72c6f 
>   khtml/java/CMakeLists.txt bb6ab56 
>   khtml/java/tests/CMakeLists.txt 55b38da 
>   kinit/CMakeLists.txt 656d2a7 
>   kio/CMakeLists.txt c5cc280 
>   kjsembed/kjscmd/CMakeLists.txt 9ec86dc 
>   staging/kde4attic/src/CMakeLists.txt 31e36e5 
>   staging/kde4support/CMakeLists.txt b01602e 
>   staging/kde4support/autotests/CMakeLists.txt 0e674ac 
>   staging/kde4support/src/CMakeLists.txt 96ba1ad 
>   staging/kde4support/tests/CMakeLists.txt 4e228c3 
>   staging/kwidgets/tests/CMakeLists.txt a847d08 
> 
> Diff: http://git.reviewboard.kde.org/r/111491/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Port
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130713/d8c0548a/attachment.html>