Review Request 111491: Rename kde4support framework to KDE4Support

[Alexander Neundorf]

On Saturday 13 July 2013, Kevin Ottens wrote:
> > On July 12, 2013, 8:02 p.m., Alexander Neundorf wrote:
> > > Thanks for working on this.
> > > 
> > > One more thing: maybe, instead of using the new target name KDE4Support
> > > everywhere directly, ${KDE4Support_LIBRARIES} could be used already
> > > now. Not within kde4support, but in kdelibs in places where
> > > ${KDE4Support_LIBRARIES} is already set. This happens currently in the
> > > toplevel CMakeLists.txt, but after add_subdirectory(staging). Maybe it
> > > could be moved before add_subdirectory(staging).
> > > 
> > > Then it doesn't have to be changed again later on when kde4support will
> > > have moved from staging to an independent framework. The name of the
> > > imported target will then be "KF5::KDE4Support", while it is now
> > > "KDE4__kde4support", and by using the variable
> > > ${KDE4Support_LIBRARIES} users are isolated from such changes.
> 
> Please discuss that with Stephen then. I thought the consensus the last
> time it got discussed was to use target names directly. Which is what
> we've been doing everywhere so far.
> 
> So I advise the following:
>  * Discuss that again if you feel that's needed, depending on the
> conclusion we will adjust (or not) our CMakeLists.txt files 

The conclusion was (there were multiple discussions, on kde-frameworks-devel, 
on cmake-devel, maybe also private mails) that it is ok to use the imported 
target names of Qt5, for everything else the variable names should be used:
http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/6877

It is ok for Qt5 since Stephen is maintaining the Config.cmake files for Qt5, 
and if he decides that's how Qt5 shall be used, so be it.
Somewhere Stephen also agreed that he would not object to using the variables 
instead of the imported targets directly in kdelibs. I don't remember where 
that mail was.


> * Let this patch and its friends in, if something is unclear on that topic
> it's no reason to block them.

I didn't feel like I "blocked" it. I gave the feedback I found necessary, and 
since he is touching the code right now anyway, it would have been a good 
chance to change it to use variables, otherwise somebody else, e.g. me, has to 
go over all those places once more.


Alex