<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111491/">http://git.reviewboard.kde.org/r/111491/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 12th, 2013, 8:02 p.m. UTC, <b>Alexander Neundorf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for working on this.
One more thing: maybe, instead of using the new target name KDE4Support everywhere directly, ${KDE4Support_LIBRARIES} could be used already now. Not within kde4support, but in kdelibs in places where ${KDE4Support_LIBRARIES} is already set. This happens currently in the toplevel CMakeLists.txt, but after add_subdirectory(staging). Maybe it could be moved before add_subdirectory(staging).
Then it doesn't have to be changed again later on when kde4support will have moved from staging to an independent framework. The name of the imported target will then be "KF5::KDE4Support", while it is now "KDE4__kde4support", and by using the variable ${KDE4Support_LIBRARIES} users are isolated from such changes.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please discuss that with Stephen then. I thought the consensus the last time it got discussed was to use target names directly. Which is what we've been doing everywhere so far.
So I advise the following:
* Discuss that again if you feel that's needed, depending on the conclusion we will adjust (or not) our CMakeLists.txt files
* Let this patch and its friends in, if something is unclear on that topic it's no reason to block them.</pre>
<br />
<p>- Kevin</p>
<br />
<p>On July 12th, 2013, 12:49 p.m. UTC, Benjamin Port wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Benjamin Port.</div>
<p style="color: grey;"><i>Updated July 12, 2013, 12:49 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In order to have all frameworks using the same name policy (i.e. use CamelCase for libraries names) rename kde4support framework lib to KDE4Support</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(a03f33b)</span></li>
<li>cmake/modules/FindKDE4Internal.cmake <span style="color: grey">(8786a9d)</span></li>
<li>interfaces/kimproxy/library/CMakeLists.txt <span style="color: grey">(5bc4b4d)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(b6d5b30)</span></li>
<li>kdewidgets/CMakeLists.txt <span style="color: grey">(1f72c6f)</span></li>
<li>khtml/java/CMakeLists.txt <span style="color: grey">(bb6ab56)</span></li>
<li>khtml/java/tests/CMakeLists.txt <span style="color: grey">(55b38da)</span></li>
<li>kinit/CMakeLists.txt <span style="color: grey">(656d2a7)</span></li>
<li>kio/CMakeLists.txt <span style="color: grey">(c5cc280)</span></li>
<li>kjsembed/kjscmd/CMakeLists.txt <span style="color: grey">(9ec86dc)</span></li>
<li>staging/kde4attic/src/CMakeLists.txt <span style="color: grey">(31e36e5)</span></li>
<li>staging/kde4support/CMakeLists.txt <span style="color: grey">(b01602e)</span></li>
<li>staging/kde4support/autotests/CMakeLists.txt <span style="color: grey">(0e674ac)</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(96ba1ad)</span></li>
<li>staging/kde4support/tests/CMakeLists.txt <span style="color: grey">(4e228c3)</span></li>
<li>staging/kwidgets/tests/CMakeLists.txt <span style="color: grey">(a847d08)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111491/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>