Review Request 110988: Port kio-file to QFile

[Martin Klapetek]

> On July 3, 2013, 11:07 a.m., David Faure wrote:
> > Did you follow the instructions on http://community.kde.org/Frameworks/Building#Running_unit_tests ?
> > 
> > You need a separate dbus session and you need to run kdeinit5 by hand, before you can run tests that use kioslaves.
> > And of course you need to "make install" before all that.
> > 
> > Feel free to use "make Experimental" so that the test results are uploaded to my.cdash.org too, then I can see them (if you point me to them).

Update: I got the unit tests running, thanks for the pointers. Some of them fail, so I'm trying to fix the code now. Will update this once all tests pass again (turns out to be bit harder than I expected).


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110988/#review35503
-----------------------------------------------------------


On June 25, 2013, 8:08 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110988/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 8:08 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Ports away kioslave/file from unix/kde specific calls to QFile calls
> 
> 
> Diffs
> -----
> 
>   kioslave/file/file.h 93aeef4 
>   kioslave/file/file.cpp 6b8b268 
>   kioslave/file/file_unix.cpp 8b92e06 
> 
> Diff: http://git.reviewboard.kde.org/r/110988/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130708/c1c04bf9/attachment.html>