Review Request 110988: Port kio-file to QFile
Martin Klapetek
martin.klapetek at gmail.com
Mon Jul 8 21:16:24 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110988/#review35768
-----------------------------------------------------------
kioslave/file/file.cpp
<http://git.reviewboard.kde.org/r/110988/#comment26216>
I have a question about this - KDE::rename seems to always overwrite the dest_orig file, whereas QFile::rename does never overwrite the target file (this change fails the tests (the QFile::rename fails) even though it seems correct).
Should I just remove the dest_orig file before the rename?
- Martin Klapetek
On June 25, 2013, 8:08 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110988/
> -----------------------------------------------------------
>
> (Updated June 25, 2013, 8:08 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Ports away kioslave/file from unix/kde specific calls to QFile calls
>
>
> Diffs
> -----
>
> kioslave/file/file.h 93aeef4
> kioslave/file/file.cpp 6b8b268
> kioslave/file/file_unix.cpp 8b92e06
>
> Diff: http://git.reviewboard.kde.org/r/110988/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130708/d3b26a3f/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list