<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110988/">http://git.reviewboard.kde.org/r/110988/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 3rd, 2013, 11:07 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Did you follow the instructions on http://community.kde.org/Frameworks/Building#Running_unit_tests ?
You need a separate dbus session and you need to run kdeinit5 by hand, before you can run tests that use kioslaves.
And of course you need to "make install" before all that.
Feel free to use "make Experimental" so that the test results are uploaded to my.cdash.org too, then I can see them (if you point me to them).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Update: I got the unit tests running, thanks for the pointers. Some of them fail, so I'm trying to fix the code now. Will update this once all tests pass again (turns out to be bit harder than I expected).</pre>
<br />
<p>- Martin</p>
<br />
<p>On June 25th, 2013, 8:08 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated June 25, 2013, 8:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ports away kioslave/file from unix/kde specific calls to QFile calls</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/file/file.h <span style="color: grey">(93aeef4)</span></li>
<li>kioslave/file/file.cpp <span style="color: grey">(6b8b268)</span></li>
<li>kioslave/file/file_unix.cpp <span style="color: grey">(8b92e06)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110988/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>