Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont

[Aleix Pol Gonzalez]

> On July 8, 2013, 11:19 a.m., Kevin Ottens wrote:
> > khtml/khtml_settings.cpp, line 30
> > <http://git.reviewboard.kde.org/r/111409/diff/2/?file=169204#file169204line30>
> >
> >     Huh? Shouldn't be needed anymore.

It's needed for KDE_DEFAULT_CHANGECURSOR.


> On July 8, 2013, 11:19 a.m., Kevin Ottens wrote:
> > staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp, line 57
> > <http://git.reviewboard.kde.org/r/111409/diff/2/?file=169211#file169211line57>
> >
> >     Agreed but should be in a different commit.

Agreed


> On July 8, 2013, 11:19 a.m., Kevin Ottens wrote:
> > kdeui/util/kglobalsettings.cpp, line 162
> > <http://git.reviewboard.kde.org/r/111409/diff/2/?file=169202#file169202line162>
> >
> >     What is it doing in that patch? I'm confused.

After moving the fonts to KPlatformTheme, the only remaining thing in the KGlobalSettingsData was the mouse settings, so I moved them to the KGlobalSettings::Private class, it seemed to me there was little reason to do it otherwise.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111409/#review35724
-----------------------------------------------------------


On July 5, 2013, 6:24 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111409/
> -----------------------------------------------------------
> 
> (Updated July 5, 2013, 6:24 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Finally my patch in Qt seems that will get to the dev branch soon, so let's start using it.
> 
> - Move the code from KGlobalSettings to the KDE platform theme to handle fonts properly.
> - Port uses of KGlobalSettings::*Fonts to newer alternatives.
> - Drop some MacOS switches regarding the fonts. It doesn't make sense since on MacOS we'll be running the MacOS QPA.
> 
> 
> NOTE: KGlobalSettings::menuFont, toolBarFont and taskBarFont have some weird workaround that I'm unsure how to fix. Maybe I should instantiate one of them?
> 
> 
> Diffs
> -----
> 
>   kdeui/dialogs/kaboutapplicationdialog.cpp d656fa2 
>   kdeui/dialogs/kshortcutseditor.cpp 5fad58b 
>   kdeui/fonts/kfontcombobox.cpp 7097ec3 
>   kdeui/util/kglobalsettings.cpp 5aad31f 
>   khtml/css/cssstyleselector.cpp b5eb370 
>   khtml/khtml_settings.cpp 5ed0aeb 
>   khtml/rendering/render_replaced.cpp 7872838 
>   khtml/xml/dom_docimpl.cpp f30b244 
>   kio/kfile/kpropertiesdialog.cpp 850a509 
>   kio/kssl/ksslcertdialog.cpp 65301a6 
>   staging/frameworkintegration/src/platformtheme/CMakeLists.txt 8cc5614 
>   staging/frameworkintegration/src/platformtheme/kdeplatformtheme.h 4bd1eae 
>   staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp fba7d13 
>   staging/frameworkintegration/src/platformtheme/kglobalsettingsdata.h PRE-CREATION 
>   staging/frameworkintegration/src/platformtheme/kglobalsettingsdata.cpp PRE-CREATION 
>   staging/kde4attic/src/kcupsoptionsjobwidget_p.cpp 15771ec 
>   staging/kde4attic/src/kdatepicker.cpp 8006e31 
>   staging/kde4attic/src/kdatetable.cpp 6f1832f 
>   tier1/kwidgetsaddons/src/kfontchooser.cpp 53a4a90 
> 
> Diff: http://git.reviewboard.kde.org/r/111409/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130708/ae074707/attachment-0001.html>