<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111409/">http://git.reviewboard.kde.org/r/111409/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 8th, 2013, 11:19 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111409/diff/2/?file=169202#file169202line162" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/util/kglobalsettings.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class KGlobalSettings::Private</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">94</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">dropMouseSettingsCache</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What is it doing in that patch? I'm confused.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After moving the fonts to KPlatformTheme, the only remaining thing in the KGlobalSettingsData was the mouse settings, so I moved them to the KGlobalSettings::Private class, it seemed to me there was little reason to do it otherwise.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 8th, 2013, 11:19 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111409/diff/2/?file=169204#file169204line30" style="color: black; font-weight: bold; text-decoration: underline;">khtml/khtml_settings.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <kglobalsettings.h></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Huh? Shouldn't be needed anymore.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's needed for KDE_DEFAULT_CHANGECURSOR.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 8th, 2013, 11:19 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111409/diff/2/?file=169211#file169211line57" style="color: black; font-weight: bold; text-decoration: underline;">staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KdePlatformTheme::KdePlatformTheme()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">57</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="o">*</span><span class="n">it</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Agreed but should be in a different commit.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Agreed</pre>
<br />
<p>- Aleix</p>
<br />
<p>On July 5th, 2013, 6:24 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated July 5, 2013, 6:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Finally my patch in Qt seems that will get to the dev branch soon, so let's start using it.
- Move the code from KGlobalSettings to the KDE platform theme to handle fonts properly.
- Port uses of KGlobalSettings::*Fonts to newer alternatives.
- Drop some MacOS switches regarding the fonts. It doesn't make sense since on MacOS we'll be running the MacOS QPA.
NOTE: KGlobalSettings::menuFont, toolBarFont and taskBarFont have some weird workaround that I'm unsure how to fix. Maybe I should instantiate one of them?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/dialogs/kaboutapplicationdialog.cpp <span style="color: grey">(d656fa2)</span></li>
<li>kdeui/dialogs/kshortcutseditor.cpp <span style="color: grey">(5fad58b)</span></li>
<li>kdeui/fonts/kfontcombobox.cpp <span style="color: grey">(7097ec3)</span></li>
<li>kdeui/util/kglobalsettings.cpp <span style="color: grey">(5aad31f)</span></li>
<li>khtml/css/cssstyleselector.cpp <span style="color: grey">(b5eb370)</span></li>
<li>khtml/khtml_settings.cpp <span style="color: grey">(5ed0aeb)</span></li>
<li>khtml/rendering/render_replaced.cpp <span style="color: grey">(7872838)</span></li>
<li>khtml/xml/dom_docimpl.cpp <span style="color: grey">(f30b244)</span></li>
<li>kio/kfile/kpropertiesdialog.cpp <span style="color: grey">(850a509)</span></li>
<li>kio/kssl/ksslcertdialog.cpp <span style="color: grey">(65301a6)</span></li>
<li>staging/frameworkintegration/src/platformtheme/CMakeLists.txt <span style="color: grey">(8cc5614)</span></li>
<li>staging/frameworkintegration/src/platformtheme/kdeplatformtheme.h <span style="color: grey">(4bd1eae)</span></li>
<li>staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp <span style="color: grey">(fba7d13)</span></li>
<li>staging/frameworkintegration/src/platformtheme/kglobalsettingsdata.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/frameworkintegration/src/platformtheme/kglobalsettingsdata.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4attic/src/kcupsoptionsjobwidget_p.cpp <span style="color: grey">(15771ec)</span></li>
<li>staging/kde4attic/src/kdatepicker.cpp <span style="color: grey">(8006e31)</span></li>
<li>staging/kde4attic/src/kdatetable.cpp <span style="color: grey">(6f1832f)</span></li>
<li>tier1/kwidgetsaddons/src/kfontchooser.cpp <span style="color: grey">(53a4a90)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111409/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>