Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont
Kevin Ottens
ervin at kde.org
Mon Jul 8 11:19:08 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111409/#review35724
-----------------------------------------------------------
kdeui/util/kglobalsettings.cpp
<http://git.reviewboard.kde.org/r/111409/#comment26178>
What is it doing in that patch? I'm confused.
kdeui/util/kglobalsettings.cpp
<http://git.reviewboard.kde.org/r/111409/#comment26179>
ditto.
khtml/css/cssstyleselector.cpp
<http://git.reviewboard.kde.org/r/111409/#comment26185>
Nitpick: We tend to favor class only includes nowadays.
khtml/khtml_settings.cpp
<http://git.reviewboard.kde.org/r/111409/#comment26184>
Huh? Shouldn't be needed anymore.
khtml/rendering/render_replaced.cpp
<http://git.reviewboard.kde.org/r/111409/#comment26186>
All the changes in this file should be part of a different commit, it has nothing to do with fonts.
staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp
<http://git.reviewboard.kde.org/r/111409/#comment26187>
Agreed but should be in a different commit.
staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp
<http://git.reviewboard.kde.org/r/111409/#comment26188>
ditto.
staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp
<http://git.reviewboard.kde.org/r/111409/#comment26189>
Unrelated change.
- Kevin Ottens
On July 5, 2013, 6:24 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111409/
> -----------------------------------------------------------
>
> (Updated July 5, 2013, 6:24 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Finally my patch in Qt seems that will get to the dev branch soon, so let's start using it.
>
> - Move the code from KGlobalSettings to the KDE platform theme to handle fonts properly.
> - Port uses of KGlobalSettings::*Fonts to newer alternatives.
> - Drop some MacOS switches regarding the fonts. It doesn't make sense since on MacOS we'll be running the MacOS QPA.
>
>
> NOTE: KGlobalSettings::menuFont, toolBarFont and taskBarFont have some weird workaround that I'm unsure how to fix. Maybe I should instantiate one of them?
>
>
> Diffs
> -----
>
> kdeui/dialogs/kaboutapplicationdialog.cpp d656fa2
> kdeui/dialogs/kshortcutseditor.cpp 5fad58b
> kdeui/fonts/kfontcombobox.cpp 7097ec3
> kdeui/util/kglobalsettings.cpp 5aad31f
> khtml/css/cssstyleselector.cpp b5eb370
> khtml/khtml_settings.cpp 5ed0aeb
> khtml/rendering/render_replaced.cpp 7872838
> khtml/xml/dom_docimpl.cpp f30b244
> kio/kfile/kpropertiesdialog.cpp 850a509
> kio/kssl/ksslcertdialog.cpp 65301a6
> staging/frameworkintegration/src/platformtheme/CMakeLists.txt 8cc5614
> staging/frameworkintegration/src/platformtheme/kdeplatformtheme.h 4bd1eae
> staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp fba7d13
> staging/frameworkintegration/src/platformtheme/kglobalsettingsdata.h PRE-CREATION
> staging/frameworkintegration/src/platformtheme/kglobalsettingsdata.cpp PRE-CREATION
> staging/kde4attic/src/kcupsoptionsjobwidget_p.cpp 15771ec
> staging/kde4attic/src/kdatepicker.cpp 8006e31
> staging/kde4attic/src/kdatetable.cpp 6f1832f
> tier1/kwidgetsaddons/src/kfontchooser.cpp 53a4a90
>
> Diff: http://git.reviewboard.kde.org/r/111409/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130708/d32e3142/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list