Review Request 111298: Add a URL handler for help:/// urls

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111298/#review35386
-----------------------------------------------------------



staging/kwidgets/src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/111298/#comment25926>

    everything else is in a subdir. utils/ would be good, I guess?



staging/kwidgets/src/urlhandler.cpp
<http://git.reviewboard.kde.org/r/111298/#comment25927>

    So, what should happen with help:/foo, i.e. when the path isn't empty ?



staging/kwidgets/src/urlhandler.cpp
<http://git.reviewboard.kde.org/r/111298/#comment25928>

    applicationName() is static, no need for the instance()->



staging/kwidgets/src/urlhandler.cpp
<http://git.reviewboard.kde.org/r/111298/#comment25931>

    Why while(), if we exit unconditionally from within the loop? if() would do, right?
    
    And then the "break" would actually exit the foreach too, which is even better.



staging/kwidgets/src/urlhandler.cpp
<http://git.reviewboard.kde.org/r/111298/#comment25929>

    "QDesktopServices does not take ownership of handlers" says the docu -> the handler is leaked.
    
    Q_GLOBAL_STATIC to the rescue.


- David Faure


On July 1, 2013, 5:13 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111298/
> -----------------------------------------------------------
> 
> (Updated July 1, 2013, 5:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Following a task in the kdelibs_cleanup Epics, make it so Qt can properly open help:// urls.
> 
> I added some "magic" query arguments so we can be passed the application in case we want to deprecate KHelpClient::invokeHelp, I'm unsure if we should port the invokeHelp code to call this.
> 
> 
> Diffs
> -----
> 
>   staging/kwidgets/src/CMakeLists.txt e337b81 
>   staging/kwidgets/src/urlhandler.cpp PRE-CREATION 
>   staging/kwidgets/tests/CMakeLists.txt f173b80 
>   staging/kwidgets/tests/openurltest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111298/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130701/e4da4b19/attachment-0001.html>