Review Request 111298: Add a URL handler for help:/// urls

[Aleix Pol Gonzalez]

> On July 1, 2013, 5:47 p.m., David Faure wrote:
> > staging/kwidgets/src/CMakeLists.txt, line 29
> > <http://git.reviewboard.kde.org/r/111298/diff/3/?file=166985#file166985line29>
> >
> >     everything else is in a subdir. utils/ would be good, I guess?

I'll do that, I didn't put it in a subdir because we're not installing any API, so it's kind of a special thing.


> On July 1, 2013, 5:47 p.m., David Faure wrote:
> > staging/kwidgets/src/urlhandler.cpp, line 44
> > <http://git.reviewboard.kde.org/r/111298/diff/3/?file=166986#file166986line44>
> >
> >     So, what should happen with help:/foo, i.e. when the path isn't empty ?

Then we consider that the URL is already correct and it's passed along.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111298/#review35386
-----------------------------------------------------------


On July 1, 2013, 5:13 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111298/
> -----------------------------------------------------------
> 
> (Updated July 1, 2013, 5:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Following a task in the kdelibs_cleanup Epics, make it so Qt can properly open help:// urls.
> 
> I added some "magic" query arguments so we can be passed the application in case we want to deprecate KHelpClient::invokeHelp, I'm unsure if we should port the invokeHelp code to call this.
> 
> 
> Diffs
> -----
> 
>   staging/kwidgets/src/CMakeLists.txt e337b81 
>   staging/kwidgets/src/urlhandler.cpp PRE-CREATION 
>   staging/kwidgets/tests/CMakeLists.txt f173b80 
>   staging/kwidgets/tests/openurltest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111298/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130702/ac122a7f/attachment.html>