Review Request 111298: Add a URL handler for help:/// urls
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Jul 1 17:13:03 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111298/
-----------------------------------------------------------
(Updated July 1, 2013, 5:13 p.m.)
Review request for KDE Frameworks.
Changes
-------
Adds a test that makes sure it works, moves it into a library.
This means that any application that links against KWidgets will magically get help:/ working with openUrl.
This is needed because we want this behavior on every KDE application, regardless of what platform we're running it on.
Description
-------
Following a task in the kdelibs_cleanup Epics, make it so Qt can properly open help:// urls.
I added some "magic" query arguments so we can be passed the application in case we want to deprecate KHelpClient::invokeHelp, I'm unsure if we should port the invokeHelp code to call this.
Diffs (updated)
-----
staging/kwidgets/src/CMakeLists.txt e337b81
staging/kwidgets/src/urlhandler.cpp PRE-CREATION
staging/kwidgets/tests/CMakeLists.txt f173b80
staging/kwidgets/tests/openurltest.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/111298/diff/
Testing
-------
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130701/60d382b7/attachment.html>
More information about the Kde-frameworks-devel
mailing list