Review Request 108263: kcalendarsystem: Merge KCalendarSystemQDate into KCalendarSystemGregorian.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108263/#review25784
-----------------------------------------------------------


This review has been submitted with commit f20cdc3fda7c77d79c63201c5f33063d9a3e51fc by Jon Severinsson to branch frameworks.

- Commit Hook


On Jan. 8, 2013, 12:26 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108263/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2013, 12:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> QDate uses a proleptic gregorian calendar system as of Qt5, so the two
> is (or at least should be) identical.
> 
> Also update the new merged calendar to match the new (larger) QDate range.
> 
> 
> This is the last piece to get kcalendartest to pass on Qt5, but will unfortunately cause it to fail on Qt4 instead (as QDate behaves differently for dates prior to 15 October 1582). As we are about to drop support for Qt4, I think that tradeoff is worthwhile.
> 
> 
> Diffs
> -----
> 
>   kdecore/CMakeLists.txt 0d3eb65 
>   kdecore/date/kcalendarsystem.cpp 198a863 
>   kdecore/date/kcalendarsystemgregorian.cpp 663cd1b 
>   kdecore/date/kcalendarsystemgregorian_p.h 6ba9088 
>   kdecore/date/kcalendarsystemminguo.cpp 449d103 
>   kdecore/date/kcalendarsystemqdate.cpp f07e93b 
>   kdecore/date/kcalendarsystemqdate_p.h 9363fff 
>   kdecore/date/kcalendarsystemthai.cpp bb89d1a 
>   kdecore/date/kdatetime.cpp aa0180c 
>   kdecore/localization/klocale.h 83f736a 
>   kdecore/localization/klocale_kde.cpp bd76dd1 
>   kdecore/tests/kcalendartest.h 505c137 
>   kdecore/tests/kcalendartest.cpp d236dce 
>   kdecore/tests/klocaletest.cpp 914a28f 
> 
> Diff: http://git.reviewboard.kde.org/r/108263/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130119/7274cc57/attachment.html>