Patch: port kDebug(*) to qDebug()

[David Faure]

On Tuesday 08 January 2013 17:54:33 Jignesh Kakadiya wrote:
> Hi David,
> 
> I have ported all kDebug calls(including area number) to //qDebug() in
> kio/kio directory. Please review it.

Thanks!

Just one thing, I see:

  //qDebug()( 7044 )

That's not going to compile when uncommented.

This seems to be an issue only in the first file, all others seem OK?


> --- a/kio/kio/kfileitem.h
> +++ b/kio/kio/kfileitem.h
> @@ -676,7 +676,7 @@ KIO_EXPORT QDataStream & operator<< ( QDataStream & s, const KFileItem & a );
>  KIO_EXPORT QDataStream & operator>> ( QDataStream & s, KFileItem & a );
>  
>  /**
> - * Support for qDebug() << aFileItem
> + * Support for //qDebug() << aFileItem
>   * \since 4.4
>   */
>  KIO_EXPORT QDebug operator<<(QDebug stream, const KFileItem& item);

This one should be reverted. You didn't review your own patch :-)

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5