<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108263/">http://git.reviewboard.kde.org/r/108263/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit f20cdc3fda7c77d79c63201c5f33063d9a3e51fc by Jon Severinsson to branch frameworks.</pre>
<br />
<p>- Commit</p>
<br />
<p>On January 8th, 2013, 12:26 p.m. UTC, Jon Severinsson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Jon Severinsson.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2013, 12:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QDate uses a proleptic gregorian calendar system as of Qt5, so the two
is (or at least should be) identical.
Also update the new merged calendar to match the new (larger) QDate range.
This is the last piece to get kcalendartest to pass on Qt5, but will unfortunately cause it to fail on Qt4 instead (as QDate behaves differently for dates prior to 15 October 1582). As we are about to drop support for Qt4, I think that tradeoff is worthwhile.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/CMakeLists.txt <span style="color: grey">(0d3eb65)</span></li>
<li>kdecore/date/kcalendarsystem.cpp <span style="color: grey">(198a863)</span></li>
<li>kdecore/date/kcalendarsystemgregorian.cpp <span style="color: grey">(663cd1b)</span></li>
<li>kdecore/date/kcalendarsystemgregorian_p.h <span style="color: grey">(6ba9088)</span></li>
<li>kdecore/date/kcalendarsystemminguo.cpp <span style="color: grey">(449d103)</span></li>
<li>kdecore/date/kcalendarsystemqdate.cpp <span style="color: grey">(f07e93b)</span></li>
<li>kdecore/date/kcalendarsystemqdate_p.h <span style="color: grey">(9363fff)</span></li>
<li>kdecore/date/kcalendarsystemthai.cpp <span style="color: grey">(bb89d1a)</span></li>
<li>kdecore/date/kdatetime.cpp <span style="color: grey">(aa0180c)</span></li>
<li>kdecore/localization/klocale.h <span style="color: grey">(83f736a)</span></li>
<li>kdecore/localization/klocale_kde.cpp <span style="color: grey">(bd76dd1)</span></li>
<li>kdecore/tests/kcalendartest.h <span style="color: grey">(505c137)</span></li>
<li>kdecore/tests/kcalendartest.cpp <span style="color: grey">(d236dce)</span></li>
<li>kdecore/tests/klocaletest.cpp <span style="color: grey">(914a28f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108263/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>