Patch: port kDebug(*) to qDebug()

[Jignesh Kakadiya]

Hi David,

I have fixed the above changes and also there are few >=2 liner kDebug
calls. I have replaced it with /* qDebug. And yes it compiles successfully.
Please review it.

Thanks,
Jignesh


On Tue, Jan 8, 2013 at 6:05 PM, David Faure <faure at kde.org> wrote:

> On Tuesday 08 January 2013 17:54:33 Jignesh Kakadiya wrote:
> > Hi David,
> >
> > I have ported all kDebug calls(including area number) to //qDebug() in
> > kio/kio directory. Please review it.
>
> Thanks!
>
> Just one thing, I see:
>
>   //qDebug()( 7044 )
>
> That's not going to compile when uncommented.
>
> This seems to be an issue only in the first file, all others seem OK?
>
>
> > --- a/kio/kio/kfileitem.h
> > +++ b/kio/kio/kfileitem.h
> > @@ -676,7 +676,7 @@ KIO_EXPORT QDataStream & operator<< ( QDataStream &
> s, const KFileItem & a );
> >  KIO_EXPORT QDataStream & operator>> ( QDataStream & s, KFileItem & a );
> >
> >  /**
> > - * Support for qDebug() << aFileItem
> > + * Support for //qDebug() << aFileItem
> >   * \since 4.4
> >   */
> >  KIO_EXPORT QDebug operator<<(QDebug stream, const KFileItem& item);
>
> This one should be reverted. You didn't review your own patch :-)
>
> --
> David Faure, faure at kde.org, http://www.davidfaure.fr
> Working on KDE, in particular KDE Frameworks 5
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130109/77e7fbc5/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kDebug_to_qDebug.patch
Type: application/octet-stream
Size: 216353 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130109/77e7fbc5/attachment-0001.obj>