Review Request 114703: Improve dependency specification for kdesignerplugin

[Martin Gräßlin]

> On Dec. 29, 2013, 10:55 a.m., David Faure wrote:
> > This actually broke the build for me.
> > 
> > 
> > # kdesrc-build running: 'gmake' '-j8'
> > # from directory: /d/kde/build/5/frameworks/kdesignerplugin
> > CMake Warning at /d/kde/inst/kde_frameworks/lib64/cmake/KF5WebKit/KF5WebKitConfig.cmake:31 (find_package):
> >   By not providing "FindQt5WebkitWidgets.cmake" in CMAKE_MODULE_PATH this
> >   project has asked CMake to find a package configuration file provided by
> >   "Qt5WebkitWidgets", but CMake did not find one.
> > 
> >   Could not find a package configuration file provided by "Qt5WebkitWidgets"
> >   (requested version 5.2) with any of the following names:
> > 
> >     Qt5WebkitWidgetsConfig.cmake
> >     qt5webkitwidgets-config.cmake
> > 
> >   Add the installation prefix of "Qt5WebkitWidgets" to CMAKE_PREFIX_PATH or
> >   set "Qt5WebkitWidgets_DIR" to a directory containing one of the above
> >   files.  If "Qt5WebkitWidgets" provides a separate development package or
> >   SDK, be sure it has been installed.
> > Call Stack (most recent call first):
> >   /d/kde/inst/kde_frameworks/lib64/cmake/KF5WebKit/KF5WebKitConfig.cmake:54 (find_dependency)
> >   CMakeLists.txt:72 (find_package)
> > 
> > 
> > CMake Error at /d/kde/inst/kde_frameworks/lib64/cmake/KF5WebKit/KF5WebKitConfig.cmake:57 (include):
> >   include could not find load file:
> > 
> >     /d/kde/inst/kde_frameworks/lib64/cmake/KF5WebKit/KF5WebkitTargets.cmake
> > Call Stack (most recent call first):
> >   CMakeLists.txt:72 (find_package)
> > 
> > 
> > -- 
> > 
> > 
> > 
> > I do have libQt5WebKitWidgets.so.5.2.0 and qtbase/lib/cmake/Qt5WebKitWidgets/Qt5WebKitWidgetsConfig.cmake
> > 
> > Oh, uppercase 'K' .... will fix.

It also broke on Jenkins: http://build.kde.org/job/kdesignerplugin_master_qt5/8/


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114703/#review46358
-----------------------------------------------------------


On Dec. 28, 2013, 6:37 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114703/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2013, 6:37 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesignerplugin
> 
> 
> Description
> -------
> 
> Improve dependency specification
> 
> * Add a find_package for Qt5WebKitWidgets
> * Make most frameworks deps optional (so it is possible to just build
>   the kgendesignerplugin utility, and not the actual plugins)
> * Get rid of the cruft from when it was in the kdelibs repo
> 
> 
> NB: this doesn't need to go into TP1, but if I don't post these patches, I'll forget I have them.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 38424b468d97532ffd1d19bc353c92b29a9f38b0 
>   src/CMakeLists.txt 3e51888614358e71756774f6bbfd5d3c14921947 
> 
> Diff: https://git.reviewboard.kde.org/r/114703/diff/
> 
> 
> Testing
> -------
> 
> Still builds fine.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131229/ccb9383b/attachment.html>