<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114703/">https://git.reviewboard.kde.org/r/114703/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 29th, 2013, 10:55 a.m. CET, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This actually broke the build for me.
# kdesrc-build running: 'gmake' '-j8'
# from directory: /d/kde/build/5/frameworks/kdesignerplugin
CMake Warning at /d/kde/inst/kde_frameworks/lib64/cmake/KF5WebKit/KF5WebKitConfig.cmake:31 (find_package):
By not providing "FindQt5WebkitWidgets.cmake" in CMAKE_MODULE_PATH this
project has asked CMake to find a package configuration file provided by
"Qt5WebkitWidgets", but CMake did not find one.
Could not find a package configuration file provided by "Qt5WebkitWidgets"
(requested version 5.2) with any of the following names:
Qt5WebkitWidgetsConfig.cmake
qt5webkitwidgets-config.cmake
Add the installation prefix of "Qt5WebkitWidgets" to CMAKE_PREFIX_PATH or
set "Qt5WebkitWidgets_DIR" to a directory containing one of the above
files. If "Qt5WebkitWidgets" provides a separate development package or
SDK, be sure it has been installed.
Call Stack (most recent call first):
/d/kde/inst/kde_frameworks/lib64/cmake/KF5WebKit/KF5WebKitConfig.cmake:54 (find_dependency)
CMakeLists.txt:72 (find_package)
CMake Error at /d/kde/inst/kde_frameworks/lib64/cmake/KF5WebKit/KF5WebKitConfig.cmake:57 (include):
include could not find load file:
/d/kde/inst/kde_frameworks/lib64/cmake/KF5WebKit/KF5WebkitTargets.cmake
Call Stack (most recent call first):
CMakeLists.txt:72 (find_package)
--
I do have libQt5WebKitWidgets.so.5.2.0 and qtbase/lib/cmake/Qt5WebKitWidgets/Qt5WebKitWidgetsConfig.cmake
Oh, uppercase 'K' .... will fix.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It also broke on Jenkins: http://build.kde.org/job/kdesignerplugin_master_qt5/8/</pre>
<br />
<p>- Martin</p>
<br />
<p>On December 28th, 2013, 6:37 p.m. CET, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2013, 6:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdesignerplugin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Improve dependency specification
* Add a find_package for Qt5WebKitWidgets
* Make most frameworks deps optional (so it is possible to just build
the kgendesignerplugin utility, and not the actual plugins)
* Get rid of the cruft from when it was in the kdelibs repo
NB: this doesn't need to go into TP1, but if I don't post these patches, I'll forget I have them.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still builds fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(38424b468d97532ffd1d19bc353c92b29a9f38b0)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(3e51888614358e71756774f6bbfd5d3c14921947)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114703/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>