Review Request 114704: Deprecate -n and -g options for kgendesignerplugin
Alex Merry
kde at randomguy3.me.uk
Sat Dec 28 15:03:02 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114704/
-----------------------------------------------------------
Review request for KDE Frameworks.
Repository: kdesignerplugin
Description
-------
4 commits. In reverse order:
Deprecate -n and -g options for kgendesignerplugin
The [Globals] group is a better place to set these.
Remove calls to qt5_generate_moc
kgendesignerplugin adds a #include <foo.moc> line, so automoc will do
the work for us.
Add a DefaultGroup Global option
This allows a default group to be set in the file, instead of the
command line.
Remove unused code in kgendesignerplugin
This code read entries in the .widgets file, but never actually used the
values it read.
NB: this doesn't need to go into TP1, but if I don't post these patches, I'll forget I have them.
Diffs
-----
KF5DesignerPluginMacros.cmake 43fde97f0e07a9d00d79f92bee1888bf8fcbf70c
README.md 5d5217e432c82149db2dcdacad5fdf2b8ee46a02
docs/kgendesignerplugin/man-kgendesignerplugin.1.docbook 99d424453009f756818dc9c8f3f60558b3657453
src/CMakeLists.txt 3e51888614358e71756774f6bbfd5d3c14921947
src/kgendesignerplugin.cpp 75c35d4d3aec27afe43ada35fe497857aac8e647
Diff: https://git.reviewboard.kde.org/r/114704/diff/
Testing
-------
Still builds fine, including the generated plugins.
Thanks,
Alex Merry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131228/6600bdd6/attachment.html>
More information about the Kde-frameworks-devel
mailing list