Review Request 114524: Load the kdoctools macro before trying to find the build deps

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114524/#review46281
-----------------------------------------------------------


I'm inclined to say that we don't care about the frameworks branch of kdelibs any more, except as a place to use "git log" and "git blame", and so this should be discarded.

- Alex Merry


On Dec. 18, 2013, 3:23 a.m., Christophe Giboudeaux wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114524/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2013, 3:23 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Tiny fix for kdoctools.
> 
> While trying to build the split frameworks, the ones calling kdoctools were failing because find_dependency was called before including KF5DocToolsTargets.cmake.
> 
> If find_dependency is called before, the PACKAGE_PREFIX_DIR gets changed to point to the dependency install dir.
> This causes build issues if kdoctools is installed in a different prefix since KDOCTOOLS_CUSTOMIZATION_DIR will have an incorrect value.
> 
> 
> Diffs
> -----
> 
>   tier2/kdoctools/KF5DocToolsConfig.cmake.in 94ad675 
> 
> Diff: https://git.reviewboard.kde.org/r/114524/diff/
> 
> 
> Testing
> -------
> 
> Built and installed all the framework modules in different prefixes without issue.
> 
> The commit is already in the split kdoctools repo.
> 
> 
> Thanks,
> 
> Christophe Giboudeaux
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131228/dc32b1e9/attachment.html>