Review Request 114524: Load the kdoctools macro before trying to find the build deps
Christophe Giboudeaux
cgiboudeaux at gmx.com
Sat Dec 28 14:02:44 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114524/
-----------------------------------------------------------
(Updated Dec. 28, 2013, 2:02 p.m.)
Status
------
This change has been discarded.
Review request for KDE Frameworks.
Repository: kdelibs
Description
-------
Tiny fix for kdoctools.
While trying to build the split frameworks, the ones calling kdoctools were failing because find_dependency was called before including KF5DocToolsTargets.cmake.
If find_dependency is called before, the PACKAGE_PREFIX_DIR gets changed to point to the dependency install dir.
This causes build issues if kdoctools is installed in a different prefix since KDOCTOOLS_CUSTOMIZATION_DIR will have an incorrect value.
Diffs
-----
tier2/kdoctools/KF5DocToolsConfig.cmake.in 94ad675
Diff: https://git.reviewboard.kde.org/r/114524/diff/
Testing
-------
Built and installed all the framework modules in different prefixes without issue.
The commit is already in the split kdoctools repo.
Thanks,
Christophe Giboudeaux
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131228/781dba01/attachment.html>
More information about the Kde-frameworks-devel
mailing list