Review Request 114524: Load the kdoctools macro before trying to find the build deps

Christophe Giboudeaux cgiboudeaux at gmx.com
Wed Dec 18 03:23:12 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114524/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

Tiny fix for kdoctools.

While trying to build the split frameworks, the ones calling kdoctools were failing because find_dependency was called before including KF5DocToolsTargets.cmake.

If find_dependency is called before, the PACKAGE_PREFIX_DIR gets changed to point to the dependency install dir.
This causes build issues if kdoctools is installed in a different prefix since KDOCTOOLS_CUSTOMIZATION_DIR will have an incorrect value.


Diffs
-----

  tier2/kdoctools/KF5DocToolsConfig.cmake.in 94ad675 

Diff: http://git.reviewboard.kde.org/r/114524/diff/


Testing
-------

Built and installed all the framework modules in different prefixes without issue.

The commit is already in the split kdoctools repo.


Thanks,

Christophe Giboudeaux

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131218/12550807/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list