Review Request 114185: Provide our own KFontDialog

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114185/
-----------------------------------------------------------

(Updated Dec. 8, 2013, 5:50 p.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

To brighten a bit further the e-mail I just sent to kde-frameworks at kde.org, here I'm making the PlatformTheme to use our KFontDialog, that now it's residing in KDE4Support.

I'd say this should result in a new module created, since we don't want to depend on KDE4Support, although I can see how we don't want to maintain an ABI on those classes, so forking is an option too.


Diffs
-----

  tier4/frameworkintegration/CMakeLists.txt 02b3563 
  tier4/frameworkintegration/autotests/CMakeLists.txt f126859 
  tier4/frameworkintegration/src/platformtheme/CMakeLists.txt 5d95c8a 
  tier4/frameworkintegration/src/platformtheme/kdeplatformfontdialoghelper.h PRE-CREATION 
  tier4/frameworkintegration/src/platformtheme/kdeplatformfontdialoghelper.cpp PRE-CREATION 
  tier4/frameworkintegration/src/platformtheme/kdeplatformtheme.h 69f1f44 
  tier4/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp 010eed4 

Diff: http://git.reviewboard.kde.org/r/114185/diff/


Testing
-------

Works with the kfontrequestertest.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131208/214859ff/attachment.html>