<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114185/">http://git.reviewboard.kde.org/r/114185/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Dec. 8, 2013, 5:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To brighten a bit further the e-mail I just sent to kde-frameworks@kde.org, here I'm making the PlatformTheme to use our KFontDialog, that now it's residing in KDE4Support.
I'd say this should result in a new module created, since we don't want to depend on KDE4Support, although I can see how we don't want to maintain an ABI on those classes, so forking is an option too.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works with the kfontrequestertest.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier4/frameworkintegration/CMakeLists.txt <span style="color: grey">(02b3563)</span></li>
<li>tier4/frameworkintegration/autotests/CMakeLists.txt <span style="color: grey">(f126859)</span></li>
<li>tier4/frameworkintegration/src/platformtheme/CMakeLists.txt <span style="color: grey">(5d95c8a)</span></li>
<li>tier4/frameworkintegration/src/platformtheme/kdeplatformfontdialoghelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier4/frameworkintegration/src/platformtheme/kdeplatformfontdialoghelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier4/frameworkintegration/src/platformtheme/kdeplatformtheme.h <span style="color: grey">(69f1f44)</span></li>
<li>tier4/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp <span style="color: grey">(010eed4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114185/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>